Skip to content

Conversation

@ABZhang0
Copy link
Contributor

@ABZhang0 ABZhang0 commented Aug 12, 2025

Related command

az grafana folder create, az grafana folder show, az grafana folder list, az grafana backup

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copilot AI review requested due to automatic review settings August 12, 2025 18:00
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 12, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️amg
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd grafana folder create cmd grafana folder create added parameter parent_folder

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 12, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for nested folder functionality in Azure Managed Grafana CLI commands. It allows creating subfolders within parent folders, improves folder search to handle nested structures, and updates folder listing and lookup logic to support hierarchical folder organization.

  • Added parent_folder_uid parameter to folder creation for nested folder support
  • Refactored folder listing to use a new search_folders utility function for better nested folder handling
  • Updated folder lookup logic to search by UID first, then by title for improved folder identification

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
setup.py Version bump from 2.6.1 to 2.6.2
custom.py Core implementation for nested folder support including parameter addition, refactored listing/search logic, and code extraction
_params.py Added parent_folder_uid parameter definition for CLI argument parsing
HISTORY.rst Added changelog entry documenting the new nested folder features

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Aug 12, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 12, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 12, 2025
@yonzhan yonzhan requested a review from kairu-ms August 12, 2025 22:47
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 12, 2025

Please fix CI issues

@kairu-ms kairu-ms merged commit d1abd22 into Azure:main Aug 13, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ amg-2.8.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=133672070&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot extension/grafana az grafana

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants