-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Support subfolders folder related commands #9055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| grafana folder create | cmd grafana folder create added parameter parent_folder |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for nested folder functionality in Azure Managed Grafana CLI commands. It allows creating subfolders within parent folders, improves folder search to handle nested structures, and updates folder listing and lookup logic to support hierarchical folder organization.
- Added
parent_folder_uidparameter to folder creation for nested folder support - Refactored folder listing to use a new
search_foldersutility function for better nested folder handling - Updated folder lookup logic to search by UID first, then by title for improved folder identification
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| setup.py | Version bump from 2.6.1 to 2.6.2 |
| custom.py | Core implementation for nested folder support including parameter addition, refactored listing/search logic, and code extraction |
| _params.py | Added parent_folder_uid parameter definition for CLI argument parsing |
| HISTORY.rst | Added changelog entry documenting the new nested folder features |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
Please fix CI issues |
|
[Release] Update index.json for extension [ amg-2.8.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=133672070&view=results |
Related command
az grafana folder create,az grafana folder show,az grafana folder list,az grafana backupGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)